Repositories

Add submit and show subcommands. This was used to submit the previous code review (the one with the skeleton of the tool.

<amshali@google.com>
[email protected] commented on 2015-04-23 00:10:15 with status ℹ️
Location { commit: Some("9a281046eb9a348fd95c560c7ce588e8035a0b92"), path: Some("src/review/review.go"), range: Some(Range { start_line: Some(186) }) }

_2?

<amshali@google.com>
[email protected] commented on 2015-04-23 00:10:16 with status ℹ️
Location { commit: Some("9a281046eb9a348fd95c560c7ce588e8035a0b92"), path: Some("src/repository/git.go"), range: Some(Range { start_line: Some(40) }) }

Can you comment on what it does? What's the difference between this and runGitCommandOrDie?

<amshali@google.com>
[email protected] commented on 2015-04-23 00:10:16 with status ℹ️
Location { commit: Some("9a281046eb9a348fd95c560c7ce588e8035a0b92"), path: Some("src/commands/show.go"), range: Some(Range { start_line: Some(26) }) }

Do we have to pass it if we don't use it?

<ojarjur@google.com>
[email protected] commented on 2015-04-23 00:16:24 with status ℹ️
Location { commit: Some("9a281046eb9a348fd95c560c7ce588e8035a0b92"), path: Some("src/repository/git.go"), range: Some(Range { start_line: Some(40) }) }

Done.

<ojarjur@google.com>
[email protected] commented on 2015-04-23 00:16:24 with status ℹ️
Location { commit: Some("9a281046eb9a348fd95c560c7ce588e8035a0b92"), path: Some("src/commands/show.go"), range: Some(Range { start_line: Some(26) }) }

Good point; removed.

<ojarjur@google.com>
[email protected] commented on 2015-04-23 00:16:24 with status ℹ️
Location { commit: Some("9a281046eb9a348fd95c560c7ce588e8035a0b92"), path: Some("src/review/review.go"), range: Some(Range { start_line: Some(186) }) }

Yep; that's what it does (according to the documentation).\n\nThis is just the stock timestamp format that looked the most similar to what git uses.

<amshali@google.com>
[email protected] commented on 2015-04-23 00:53:34 with status 👍