Repositories

<hazbo>
hazbo wants to merge refs/pull/23/head into refs/heads/master
2016-01-04 23:10:34

Possible bug fix for thread comment status

As pointed out in #22, the status for every comment seems to be fyi. This seems to fix that.

cla/google reported status success at 2015-12-23 16:21:39
<barbastan>
barbastan commented on 2015-12-23 18:50:51 with status ℹ️

Thanks!

Barbara

On Wednesday, December 23, 2015, Harry Lawrence [email protected] wrote:

As pointed out in #22 https://github.com/google/git-appraise/issues/22, the status for every comment seems to be fyi. This seems to fix that.


You can view, comment on, or merge this pull request online at:

https://github.com/google/git-appraise/pull/23 Commit Summary

  • Possible bug fix for thread comment status

File Changes

Patch Links:

  • https://github.com/google/git-appraise/pull/23.patch
  • https://github.com/google/git-appraise/pull/23.diff

— Reply to this email directly or view it on GitHub https://github.com/google/git-appraise/pull/23.

<hazbo>
hazbo commented on 2015-12-24 14:35:24 with status ℹ️

This may now be redundant as of #24

cla/google reported status success at 2015-12-24 14:35:25
<ojarjur>
ojarjur commented on 2016-01-04 23:10:34 with status ℹ️

There's the overall status of the entire sub-thread, and the resolved bit for the individual comment. Right now we are only displaying the overall status.

I wouldn't want to replace the overall status with the individual comment's status (which is what this PR currently does), but I would not object to displaying both statuses if we can format the output nicely.