Repositories

<jishi9>
2016-01-04 18:28:59

Fixed updateThreadsStatus to modify original thread instances, rather than modifying copies

This is a proposed fix to #22

updateThreadsStatus was not actually updating the CommentThread instances, but updating copies thereof.

<googlebot>
googlebot commented on 2015-12-24 00:07:31 with status ℹ️

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.
<jishi9>
jishi9 commented on 2015-12-24 00:12:51 with status ℹ️

I signed it!

<googlebot>
googlebot commented on 2015-12-24 00:12:52 with status ℹ️

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

cla/google reported status success at 2015-12-24 00:14:13
<googlebot>
googlebot commented on 2015-12-24 00:14:13 with status ℹ️

CLAs look good, thanks!

<ojarjur@google.com>
[email protected] commented on 2016-01-04 18:19:22 with status 👍
Location { commit: Some("39155d21212b429871826b9ce9261d5a28386f55"), path: None, range: None }
<ojarjur>
ojarjur commented on 2016-01-04 18:28:59 with status ℹ️

Thanks for doing this; good catch on the bug.