Repositories

Added an initial set of unit tests for computing the aggregate resolved status of a comment thread.

This exposed some bugs in that computation which were also fixed, and the need for more robust go docs, which were added.

<bstanley@google.com>
[email protected] commented on 2015-05-06 20:20:47 with status ℹ️

LGTM.

<amshali@google.com>
[email protected] commented on 2015-05-06 22:13:40 with status ℹ️
Location { commit: Some("aa26852425727c293a2fe32ec5dee6438ca0da16"), path: Some("src/review/review_test.go"), range: Some(Range { start_line: Some(298) }) }

Convert this into a helper method since it is repeated more than a few times.

<amshali@google.com>
[email protected] commented on 2015-05-06 22:13:40 with status ℹ️
Location { commit: Some("aa26852425727c293a2fe32ec5dee6438ca0da16"), path: Some("src/review/review.go"), range: Some(Range { start_line: Some(79) }) }

Can you comment on what's the meaning of nil return value here? What is the meaning of different values of return result here?

<amshali@google.com>
[email protected] commented on 2015-05-06 22:13:40 with status ℹ️
Location { commit: Some("aa26852425727c293a2fe32ec5dee6438ca0da16"), path: Some("src/review/review.go"), range: Some(Range { start_line: Some(45) }) }

"If it is set to true ..."

<ojarjur@google.com>
[email protected] commented on 2015-05-06 22:47:50 with status ℹ️
Location { commit: Some("aa26852425727c293a2fe32ec5dee6438ca0da16"), path: Some("src/review/review_test.go"), range: Some(Range { start_line: Some(298) }) }

Done

<ojarjur@google.com>
[email protected] commented on 2015-05-06 22:47:50 with status ℹ️
Location { commit: Some("aa26852425727c293a2fe32ec5dee6438ca0da16"), path: Some("src/review/review.go"), range: Some(Range { start_line: Some(79) }) }

Done

<ojarjur@google.com>
[email protected] commented on 2015-05-06 22:47:50 with status ℹ️
Location { commit: Some("aa26852425727c293a2fe32ec5dee6438ca0da16"), path: Some("src/review/review.go"), range: Some(Range { start_line: Some(45) }) }

Done

<amshali@google.com>
[email protected] commented on 2015-05-06 23:31:56 with status 👍