Repositories

<ojarjur@google.com>
[email protected] wants to merge refs/heads/ojarjur/set-exit-code into refs/heads/master

Set the exit status to a non-zero value when a command fails

<amshali@google.com>
[email protected] commented on 2015-05-08 04:42:50 with status ℹī¸
Location { commit: Some("82e2972e5b42b134bd0c920f47e24e7d9c224c29"), path: Some("commands/list.go"), range: Some(Range { start_line: Some(40) }) }

Are we sure listReviews is always successful?

<ojarjur@google.com>
[email protected] commented on 2015-05-08 16:09:53 with status ℹī¸
Location { commit: Some("82e2972e5b42b134bd0c920f47e24e7d9c224c29"), path: Some("commands/list.go"), range: Some(Range { start_line: Some(40) }) }

Yes, it takes no arguments, and if there are no reviews then an empty list is still a valid thing to display.

<amshali@google.com>
[email protected] commented on 2015-05-08 16:53:28 with status 👍
<bstanley@google.com>
[email protected] commented on 2015-05-08 16:54:34 with status 👍
<bstanley@google.com>
[email protected] commented on 2015-05-08 16:54:34 with status ℹī¸

LGTM