Repositories

<ojarjur@google.com>
[email protected] wants to merge refs/heads/ojarjur/contributing into refs/heads/master

Added a CONTRIBUTING file

<bstanley>
bstanley commented on 2015-06-19 23:02:01 with status 👍
<bstanley>
bstanley commented on 2015-06-19 23:02:01 with status ℹ️

I made some recommendations for wording changes. But feel free to ignore them if you don't like them. My comments are not intended to be submit-blockers.

<bstanley>
bstanley commented on 2015-06-19 23:02:01 with status ℹ️
Location { commit: Some("9430e12613ad3e72a738a7fe6eb783b30a8b984a"), path: Some("CONTRIBUTING.md"), range: Some(Range { start_line: Some(15) }) }

How about: Coordinating up front avoids frustrations later.

<bstanley>
bstanley commented on 2015-06-19 23:02:01 with status ℹ️
Location { commit: Some("9430e12613ad3e72a738a7fe6eb783b30a8b984a"), path: Some("CONTRIBUTING.md"), range: Some(Range { start_line: Some(8) }) }

A bit of a run-on sentence. Recommendation: The CLA is necessary mainly because you own the copyright to your changes, even after your contribution becomes part of our codebase. Therefore, we need your permission...

<bstanley>
bstanley commented on 2015-06-19 23:02:01 with status ℹ️
Location { commit: Some("9430e12613ad3e72a738a7fe6eb783b30a8b984a"), path: Some("CONTRIBUTING.md"), range: Some(Range { start_line: Some(11) }) }

I would modify the wording of lines 8+ through 10 to something like: The CLA also covers other miscellaneous details -- e.g., you will notify us if you know if you are aware of patent infringements in your code. You are not required to sign the CLA until after you've submitted....

<ojarjur@google.com>
[email protected] commented on 2015-06-19 23:14:38 with status 👍
Location { commit: Some("9430e12613ad3e72a738a7fe6eb783b30a8b984a"), path: None, range: None }
<ojarjur@google.com>
[email protected] commented on 2015-06-19 23:15:12 with status 👍
Location { commit: Some("9430e12613ad3e72a738a7fe6eb783b30a8b984a"), path: None, range: None }
<ojarjur@google.com>
[email protected] commented on 2015-06-19 23:16:03 with status ℹ️
Location { commit: Some("9430e12613ad3e72a738a7fe6eb783b30a8b984a"), path: None, range: None }

I incorporated most of your suggestions

<ojarjur@google.com>
[email protected] commented on 2015-06-19 23:18:12 with status ℹ️
Location { commit: Some("9430e12613ad3e72a738a7fe6eb783b30a8b984a"), path: None, range: None }

In this case I think I prefer the original wording.