Repositories

<ojarjur@google.com>
[email protected] wants to merge refs/heads/ojarjur/more-editor-support into refs/heads/master
2016-01-13 18:28:40

Consolidate the editor logic into a single place, and make it more reliable.

With this change we will try to run the editor in a shell if launching it directly does not work.

<ckerur>
ckerur commented on 2016-01-14 01:46:52 with status 👍
<ckerur>
ckerur commented on 2016-01-14 01:46:52 with status ℹ️

Minor comment

<ckerur>
ckerur commented on 2016-01-14 01:46:52 with status ℹ️
Location { commit: Some("dfdd159c9c11c08d84c8c050d2a1a4db29147916"), path: Some("commands/input/input.go"), range: Some(Range { start_line: Some(27) }) }

What happens if the command line editor session is left open ?

<ckerur>
ckerur commented on 2016-01-14 01:46:52 with status ℹ️
Location { commit: Some("dfdd159c9c11c08d84c8c050d2a1a4db29147916"), path: Some("commands/input/input.go"), range: Some(Range { start_line: Some(48) }) }

if that fails

<ojarjur@google.com>
[email protected] commented on 2016-01-14 18:31:35 with status ℹ️
Location { commit: Some("aee6f75ddd9ef88304e58356aa8d331e6923f972"), path: Some("commands/input/input.go"), range: Some(Range { start_line: Some(27) }) }

Expanded the godoc to make it more clear that shouldn't happen.

<ojarjur@google.com>
[email protected] commented on 2016-01-14 18:35:17 with status ℹ️
Location { commit: Some("aee6f75ddd9ef88304e58356aa8d331e6923f972"), path: Some("commands/input/input.go"), range: Some(Range { start_line: Some(48) }) }

Done