Repositories

<jishi9>
jishi9 wants to merge refs/pull/27/head into refs/heads/master
2016-01-04 23:06:47

Check that parent comment exists before creating a comment

A proposed fix to issue #25

Would be nice to be able to instead use the commentsByHash that is already computed in [review.loadComments](https://github.com/google/git-appraise/blob/master/review/review.go#L177). Suggestions welcome!

<googlebot>
googlebot commented on 2015-12-26 21:13:08 with status ℹ️

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

<jishi9>
jishi9 commented on 2015-12-26 21:16:41 with status ℹ️
Location { commit: Some("ec1a0bb461324ff9ad3372d59985c499299c7049"), path: Some("commands/comment.go"), range: Some(Range { start_line: Some(116) }) }

Is *commentParent necessarily a hash, or could it be some other reference resolvable to a hash?

<jishi9>
jishi9 commented on 2015-12-26 21:16:41 with status ℹ️
Location { commit: Some("ec1a0bb461324ff9ad3372d59985c499299c7049"), path: Some("commands/comment.go"), range: Some(Range { start_line: Some(117) }) }

Should this message mention the string *commentParent provided? For example: There is no matching parent comment: 11223344abcdef

<jishi9>
jishi9 commented on 2015-12-26 21:16:41 with status ℹ️
Location { commit: Some("df324616ea2bc9bf6fc7025fc80a373ecec687b6"), path: Some("commands/comment.go"), range: Some(Range { start_line: Some(116) }) }

Is *commentParent necessarily a hash, or could it be some other reference resolvable to a hash?

<jishi9>
jishi9 commented on 2015-12-26 21:16:41 with status ℹ️
Location { commit: Some("df324616ea2bc9bf6fc7025fc80a373ecec687b6"), path: Some("commands/comment.go"), range: Some(Range { start_line: Some(117) }) }

Should this message mention the string *commentParent provided? For example: There is no matching parent comment: 11223344abcdef

cla/google reported status success at 2015-12-26 21:16:44
<googlebot>
googlebot commented on 2015-12-26 21:16:44 with status ℹ️

CLAs look good, thanks!

<barbastan>
barbastan commented on 2015-12-27 15:29:57 with status ℹ️

Omar will look at this when he returns on Jan. 4th.

Thanks! Barbara

On Sat, Dec 26, 2015 at 1:16 PM, googlebot [email protected] wrote:

CLAs look good, thanks!

— Reply to this email directly or view it on GitHub https://github.com/google/git-appraise/pull/27#issuecomment-167363884.

<ojarjur@google.com>
[email protected] commented on 2016-01-04 22:44:38 with status ℹ️
Location { commit: Some("ec1a0bb461324ff9ad3372d59985c499299c7049"), path: Some("commands/comment.go"), range: Some(Range { start_line: Some(116) }) }

It has to be a hash. There are no other ways to refer to one of these comments.

<ojarjur@google.com>
[email protected] commented on 2016-01-04 22:45:59 with status ℹ️
Location { commit: Some("ec1a0bb461324ff9ad3372d59985c499299c7049"), path: Some("commands/comment.go"), range: Some(Range { start_line: Some(117) }) }

I don't feel strongly about it either way.

<ojarjur@google.com>
[email protected] commented on 2016-01-04 22:46:24 with status 👍
Location { commit: Some("ec1a0bb461324ff9ad3372d59985c499299c7049"), path: None, range: None }